Defvars cleanup #53
Merged
Defvars cleanup #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was defined with `defvar` and then made into buffer-local with (make-variable-buffer-local). The call though was only executed once, which is likely an omission as even the documentation states the variable supposed to be buffer-local. So fix that and make it truly buffer-local.
It was defined with `defvar` and then made into buffer-local with (make-variable-buffer-local). The call though was only executed once, which is likely an omission. Fix that and make it truly buffer-local.
This gets rid of repeated "defvar"s in different files by instead importing the variable from a shared location.
Now that it's exported from a common location, there's no reason it shouldn't be (besides a bug of course).
All supported Emacs versions have the variable, so no need to have it defined still.
…local There's no reason for killing (I even checked other major modes), and the make-local-variable may be replaced by just setq-local.
It's been there since 2019 and the variable has been no-op since then as well. I think it's fair to assume anyone who were still using the variable either moved on, or if they didn't notice anything, they will probably keep not noticing anything, because the variable has been no-op for so long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does defvar cleanup; most notably it moves
purescript-literateto a shared location to make other files stop doing(defvar purescript-literate), and it replaces somedefvar + make-local-variablechains with justdefvar-local.