-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fixes #12132 -- implement ssh public key fingerprints #12673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(This was mostly developed by claude-code, but eventually I got bored of baby sitting it and so I just cleaned it up myself) |
cd7538a
to
0007fb5
Compare
Two choices I made here:
My theory was that adding those by a caller is easy-ish, but undoing them is annoying. But I'm not wedded to this. |
an alternative here would be to just compute the hash, no serialization at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- CHANGELOG.rst: Language not supported
- docs/hazmat/primitives/asymmetric/serialization.rst: Language not supported
124e370
to
00c94e8
Compare
3496507
to
407cd20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the SSH spec define the md5 fingerprint as hex encoded and sha256 as base64 with no padding? If so, can we put that in a comment somewhere? 😄
Assuming that is a documented property of these fingerprints then I think it's fine to do it for the caller rather than presenting back raw digest bytes.
So, I'm not aware of a spec for this, I based this on the behavior of |
Yeah if it's just a current implementation detail I'd rather just do digest bytes with examples of how to encode it to match current ssh-keygen behavior. |
No description provided.