Adding tool response in running tool spans #2081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtyavrdhn
changed the title
adtyavrdhn
commented
Jun 26, 2025
| current_span = get_current_span() | ||
| if current_span.is_recording() and include_content: | ||
| current_span.set_attribute( | ||
| 'gen_ai.tool.call.response', |
There was a problem hiding this comment.
https://opentelemetry.io/docs/specs/semconv/registry/attributes/gen-ai/
I could not find an attribute for tool response so went with this for now
adtyavrdhn
commented
Jun 26, 2025
| if current_span.is_recording() and include_content: | ||
| current_span.set_attribute( | ||
| 'gen_ai.tool.call.response', | ||
| response_content if isinstance(response_content, str) else str(response_content), |
There was a problem hiding this comment.
Unsure about this part, should we retain the type of the tool response? Does that serve any useful case?
We could also have a helper function check against AttributeValue and fallback to str().
|
Hi @alexmojaki. I would appreciate it if could take a look. |
|
Hi @adtyavrdhn, thanks for giving this a go. The ideas were right but there were enough details that I felt iffy about that it seemed easier to just open #2109 instead. |
|
No problem, thanks for taking the time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2004