-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Release workflows: always check that the built dist is valid. #10408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually I don't understand what happened here. One action failed and another succeeeded: https://github.com/pydata/xarray/actions/workflows/pypi-release.yaml . the release is on pypi. Does anyone understand what's going on? |
Change: from typing_extensions import Self to if TYPE_CHECKING:
from typing_extensions import Self |
5 tasks
Apologies, I didn't see this PR before creating: which guards the |
6182f2c
to
cac505d
Compare
Merged
TomNicholas
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Automation
Github bots, testing workflows, release automation
plan to merge
Final call for comments
Release
Planning and tracking progress of releases
topic-documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our release action failed :( https://github.com/pydata/xarray/actions/runs/15565419295/job/43828236592 Looks like something else was dragging in
typing_extensions
earlier.