Skip to content

Release workflows: always check that the built dist is valid. #10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2025

Conversation

dcherian
Copy link
Contributor

Our release action failed :( https://github.com/pydata/xarray/actions/runs/15565419295/job/43828236592 Looks like something else was dragging in typing_extensions earlier.

@dcherian dcherian added the Release Planning and tracking progress of releases label Jun 10, 2025
@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Jun 10, 2025
@dcherian
Copy link
Contributor Author

Actually I don't understand what happened here.

One action failed and another succeeeded: https://github.com/pydata/xarray/actions/workflows/pypi-release.yaml . the release is on pypi.

Does anyone understand what's going on?

@dcherian dcherian marked this pull request as draft June 10, 2025 17:21
@max-sixty
Copy link
Collaborator

hmmm, looks like the pipeline from the Release succeeded, the pipeline from the tag failed, so it successfully pushed to PyPI

image

it looks like that's because we don't run the verify check before the release?

image

@cgohlke
Copy link

cgohlke commented Jun 11, 2025

Change:

from typing_extensions import Self

to

if TYPE_CHECKING:
    from typing_extensions import Self

at
https://github.com/pydata/xarray/blob/f1a2c08f21a8237c082913fcad2d77469448cf4c/xarray/core/accessor_dt.py#L8C1-L8C35

@sjperkins
Copy link
Contributor

Apologies, I didn't see this PR before creating:

which guards the typing_extension import as done elsewhere in the code base.

@dcherian dcherian force-pushed the fix-packaging branch 2 times, most recently from 6182f2c to cac505d Compare June 11, 2025 12:37
@dcherian dcherian requested a review from keewis June 11, 2025 12:38
@dcherian dcherian changed the title Add typing_extensions to dependencies. Update release workflows Jun 11, 2025
@dcherian dcherian marked this pull request as ready for review June 11, 2025 12:38
@dcherian dcherian mentioned this pull request Jun 12, 2025
@dcherian dcherian added the plan to merge Final call for comments label Jul 3, 2025
@dcherian dcherian changed the title Update release workflows Release workflows: always check that the built dist is valid. Jul 3, 2025
@TomNicholas TomNicholas merged commit 0db56ad into pydata:main Jul 3, 2025
37 checks passed
@dcherian dcherian deleted the fix-packaging branch July 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments Release Planning and tracking progress of releases topic-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants