Fix RangeIndex slicing #10471
Merged
Fix RangeIndex slicing #10471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benbovy
commented
Jun 30, 2025
benbovy
commented
- Closes slicing DataArray with RangeIndex coordinate can put coordinate in inconsistent state #10441
- Tests added
dcherian
reviewed
Jun 30, 2025
| @@ -84,9 +84,9 @@ def slice(self, sl: slice) -> "RangeCoordinateTransform": | |||
| # TODO: support reverse transform (i.e., start > stop)? | |||
| assert sl.start < sl.stop | |||
|
|
|||
| new_size = (sl.stop - sl.start) // sl.step | |||
There was a problem hiding this comment.
One trick I have learned is to use range objects to outsource this logic to CPython (e.g. #7586)
So you could do:
newrange = range(self.size)[sl]
start = newrange.start
step = newrange.step or 1
size = len(newrange)There was a problem hiding this comment.
Nice trick, this also allows supporting reverse indexing without additional effort.
There was a problem hiding this comment.
Actually, I remember the real API is slice.indices(size) so an alternative is :
start, stop, step = slicer.indices(self.size)
size = len(range(start, stop, step))
I think you still need to construct the range object to get the right size so not much difference
This also enables support for reverse slicing (added tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.