Skip to content

Branches of the if statement have similar implementation #10475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Branches of the if statement have similar implementation #10475

merged 2 commits into from
Jun 30, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Issue introduced by 16b53ac / #8937.

It looks like the sys.version_info >= (3, 11) test is incorrect, as typing.TypeAlias was added in version 3.10, not 3.11:

Added in version 3.10.

Note that TypeAlias itself will be deprecated:

Deprecated since version 3.12: TypeAlias is deprecated in favor of the type statement, which creates instances of TypeAliasType and which natively supports forward references. Note that while TypeAlias and TypeAliasType serve similar purposes and have similar names, they are distinct and the latter is not the type of the former. Removal of TypeAlias is not currently planned, but users are encouraged to migrate to type statements.

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@github-actions github-actions bot added topic-documentation topic-NamedArray Lightweight version of Variable labels Jun 30, 2025
@DimitriPapadopoulos
Branches of the if statement have similar implementation
5ff25e2 
Issue introduced by 16b53ac / pydata#8937.

It looks like the `sys.version_info >= (3, 11)` test is incorrect, as
`typing.TypeAlias`  was added in version 3.10, not 3.11:
	https://docs.python.org/3/library/typing.html#typing.TypeAlias
@DimitriPapadopoulos
Branches of the if statement have similar implementation
69ba406 
Introduced by 17933e7 / pydata#7426.
@max-sixty
Copy link
Collaborator

yes nice spot!

@max-sixty max-sixty merged commit e71bb12 into pydata:main Jun 30, 2025
30 of 33 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PTC-W0051 branch July 1, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic-documentation topic-NamedArray Lightweight version of Variable topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @max-sixty