Prevent pydap (dap4) to change string arrays to unicode type (testing). Fixed upstream #10482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic-documentation
CI
dcherian
reviewed
Jul 1, 2025
Mikejmnez
changed the title
|
Nice |
dcherian
reviewed
Jul 2, 2025
| # pydap <3.5.6 converts to unicode dtype=|U. Not what | ||
| # xarray expects. Thus force to bytes dtype. pydap >=3.5.6 | ||
| # does not convert to unicode. https://github.com/pydap/pydap/issues/510 | ||
| actual["bears"].values = actual["bears"].values.astype("S") |
There was a problem hiding this comment.
Just so I understand: pydap is changing behaviour and we are enforcing that new behaviour always?
There was a problem hiding this comment.
That's my understanding, too.
There was a problem hiding this comment.
Yes, sort of... It was more like pydap was always enforcing a change from "S" --> "U", which was not jiving with xarray. Beginning with the new version it will no longer enforce the change to unicode. Once the minimal pydap version moves up from 3.5.0 --> 3.5.6 this line won't be necessary.
kmuehlbauer
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pydapbackend).addednow pass on both min-dependencies environment (pydap 3.5.0which has numpy<2) and with python=3.12 (nightly?)whats-new.rst