Skip to content

Update error message regex for latest Zarr #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025
Merged

Update error message regex for latest Zarr #10485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ace10c
Update error message regex for latest Zarr
dcherian Jul 2, 2025
6d6f802
Merge branch 'main' into silence-zarr-error
dcherian Jul 2, 2025
b7d0e8f
xfail zip store test
dcherian Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xarray/tests/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,7 +2398,8 @@

def test_non_existent_store(self) -> None:
with pytest.raises(
FileNotFoundError, match="(No such file or directory|Unable to find group)"
FileNotFoundError,
match="(No such file or directory|Unable to find group|No group found)",
):
xr.open_zarr(f"{uuid.uuid4()}")

Expand Down Expand Up @@ -5444,7 +5445,7 @@

def test_cmp_local_file(self) -> None:
with self.create_datasets() as (actual, expected):
assert_equal(actual, expected)

Check failure on line 5448 in xarray/tests/test_backends.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.13 all-but-numba 

TestPydap.test_cmp_local_file

AssertionError: Left and right Dataset objects are not equal
Differing data variables:
L   bears    (i, j) <U3 72B 'ind' 'ist' 'ing' 'uis' 'hab' 'le'
R   bears    (i, j) |S4 24B b'ind' b'ist' b'ing' b'uis' b'hab' b'le'

# global attributes should be global attributes on the dataset
assert "NC_GLOBAL" not in actual.attrs
Expand Down Expand Up @@ -5491,7 +5492,7 @@
@requires_dask
def test_dask(self) -> None:
with self.create_datasets(chunks={"j": 2}) as (actual, expected):
assert_equal(actual, expected)

Check failure on line 5495 in xarray/tests/test_backends.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.13 all-but-numba 

TestPydap.test_dask

AssertionError: Left and right Dataset objects are not equal
Differing data variables:
L   bears    (i, j) <U3 72B 'ind' 'ist' 'ing' 'uis' 'hab' 'le'
R   bears    (i, j) |S4 24B b'ind' b'ist' b'ing' b'uis' b'hab' b'le'


@network
Expand Down
1 change: 1 addition & 0 deletions xarray/tests/test_backends_datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@
with xr.open_dataset(url, engine=self.engine, group="/") as expected:
assert_identical(unaligned_dict_of_datasets["/"], expected)
with xr.open_dataset(url, group="Group1", engine=self.engine) as expected:
assert_identical(unaligned_dict_of_datasets["/Group1"], expected)

Check failure on line 463 in xarray/tests/test_backends_datatree.py

View workflow job for this annotation

GitHub Actions / ubuntu-latest py3.13 flaky 

TestPyDAPDatatreeIO.test_open_groups

AssertionError: Left and right Dataset objects are not identical
Differing dimensions:
    (lat: 1, lon: 2) != (lon: 2, lat: 2)
Differing data variables:
L   group_1_var  (lat, lon) float64 16B ...
R   group_1_var  (lon, lat) float64 32B ...
with xr.open_dataset(
url,
group="/Group1/subgroup1",
Expand Down Expand Up @@ -583,6 +583,7 @@
filepath, encoding=enc, engine="zarr", zarr_format=zarr_format
)

@pytest.mark.xfail(reason="upstream zarr read-only changes have broken this test")
def test_to_zarr_zip_store(self, tmpdir, simple_datatree, zarr_format):
from zarr.storage import ZipStore

Expand Down
Loading