Skip to content

Downgrade zarr requests performance expectations for zarr 3.0.9 #10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jul 2, 2025
Merged

Downgrade zarr requests performance expectations for zarr 3.0.9 #10491

Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
01e7518
new blank whatsnew
TomNicholas Oct 24, 2024
83e553b
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Oct 24, 2024
e44326d
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 8, 2024
4e4eeb0
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 20, 2024
d858059
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 21, 2024
d377780
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 21, 2024
3132f6a
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 23, 2024
900eef5
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Nov 29, 2024
4c4462f
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Dec 4, 2024
5b9b749
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jan 6, 2025
fadb953
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jan 8, 2025
57d9d23
Merge branch 'main' of https://github.com/TomNicholas/xarray
TomNicholas Mar 13, 2025
11170fc
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Mar 19, 2025
0b8fa41
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Mar 20, 2025
f769f85
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Mar 20, 2025
4eef318
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Apr 7, 2025
29242a4
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas May 15, 2025
5d15bbd
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas May 19, 2025
b4ed8ee
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jun 20, 2025
6a23bfb
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jun 24, 2025
d87b209
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jun 27, 2025
9b39529
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jun 28, 2025
1829807
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jul 1, 2025
de02ced
Merge branch 'main' of https://github.com/pydata/xarray
TomNicholas Jul 2, 2025
d425a98
change expectations
TomNicholas Jul 2, 2025
58d615a
set apparently changed too
TomNicholas Jul 2, 2025
b09f7ce
.to_zarr is also issuing more get requests...
TomNicholas Jul 2, 2025
da5a7fe
to_zarr also issuing more set requests
TomNicholas Jul 2, 2025
d340d8e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 2, 2025
b4cb10f
more problems
TomNicholas Jul 2, 2025
8144447
just print all the changes in CI
TomNicholas Jul 2, 2025
9e9fb68
more issues
TomNicholas Jul 2, 2025
95f825d
Remove print statements
TomNicholas Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions xarray/tests/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3539,8 +3539,8 @@ def test_append(self) -> None:
if has_zarr_v3:
# TODO: verify these
expected = {
"set": 5,
"get": 4,
"set": 16,
"get": 8, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"list_dir": 2,
"list_prefix": 1,
}
Expand All @@ -3564,8 +3564,8 @@ def test_append(self) -> None:
# 6057128b: {'iter': 5, 'contains': 2, 'setitem': 5, 'getitem': 10, "listdir": 5, "list_prefix": 0}
if has_zarr_v3:
expected = {
"set": 4,
"get": 9, # TODO: fixme upstream (should be 8)
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
"list_dir": 2, # TODO: fixme upstream (should be 2)
"list_prefix": 0,
}
Expand All @@ -3587,8 +3587,8 @@ def test_append(self) -> None:

if has_zarr_v3:
expected = {
"set": 4,
"get": 9, # TODO: fixme upstream (should be 8)
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
"list_dir": 2, # TODO: fixme upstream (should be 2)
"list_prefix": 0,
}
Expand Down Expand Up @@ -3621,8 +3621,8 @@ def test_region_write(self) -> None:
with self.create_zarr_target() as store:
if has_zarr_v3:
expected = {
"set": 5,
"get": 2,
"set": 16,
"get": 8, # TODO: fixme upstream (should be 2), see https://github.com/zarr-developers/zarr-python/issues/3199
"list_dir": 2,
"list_prefix": 4,
}
Expand Down
Loading