Improve warning message and tests for timedelta decoding #10508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new warning message gives years clearer and simpler guidance on how to silence the warning. The new tests verify that `dtype` attributes on disk like `timedelta64[s]` will be decoded properly.
spencerkclark
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Thanks, looks good!
This might be sufficient to close #10382. My main takeaway there was that it would be good to include at least one variable name that triggered the warning, which is what this PR does.
| ) -> None: | ||
| timedeltas = pd.timedelta_range(0, freq="D", periods=3) | ||
| timedeltas = pd.timedelta_range(0, freq="D", periods=3, unit=original_unit) |
There was a problem hiding this comment.
I do not fully understand why mypy complains here, but we have worked around it this way in the past:
Suggested change
| timedeltas = pd.timedelta_range(0, freq="D", periods=3, unit=original_unit) | |
| timedeltas = pd.timedelta_range(0, freq="D", periods=3, unit=original_unit) # type: ignore[call-arg] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new warning message gives years clearer and simpler guidance on how to silence the warning.
The new tests verify that
dtypeattributes on disk liketimedelta64[s]will be decoded properly.