-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Invalid no-name-in-module when shadowing a base module with an alias then calling a method named format on that alias. #10409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10409 +/- ##
==========================================
- Coverage 95.90% 95.88% -0.03%
==========================================
Files 176 176
Lines 19139 19157 +18
==========================================
+ Hits 18356 18368 +12
- Misses 783 789 +6
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit e6cf8e7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @pavan-msys
@@ -0,0 +1,90 @@ | |||
# pylint: disable=missing-docstring,consider-using-with,trailing-whitespace,unused-import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a unit test class that is erroneously in the functional test directory. Functional test are raw examples of code, unit test should be elsewhere.
Type of Changes
Description
This PR fixes an issue where Pylint incorrectly raises no-name-in-module (E0611) errors for valid Python code using shadowed imports (e.g., import my_module.utils as my_module).
Closes #10193