Skip to content

Fix issues with model graph #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2025
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 3, 2025

Closes #7397

Also when working on #7820 I noticed our detection of observed variables was based on old behavior where only Cast operations were allowed in the graph. This PR fixes that as well


📚 Documentation preview 📚: https://pymc--7844.org.readthedocs.build/en/7844/

@ricardoV94 ricardoV94 changed the title Fix usses with model graph Fix issues with model graph Jul 3, 2025
@ricardoV94
Copy link
Member Author

@williambdean do you want to review?

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (965534a) to head (e9dcc27).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pymc/model/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7844   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         107      107           
  Lines       18286    18301   +15     
=======================================
+ Hits        16991    17005   +14     
- Misses       1295     1296    +1     
Files with missing lines Coverage Δ
pymc/model_graph.py 84.43% <100.00%> (-0.65%) ⬇️
pymc/model/core.py 93.35% <50.00%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 requested a review from jessegrabowski July 6, 2025 05:40
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@williambdean williambdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you OSS legend

@ricardoV94 ricardoV94 force-pushed the fix_model_graph branch 2 times, most recently from b23a979 to e9dcc27 Compare July 6, 2025 12:13
@ricardoV94 ricardoV94 merged commit ded582e into pymc-devs:main Jul 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: make_compute_graph creates self loop
3 participants