-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix issues with model graph #7844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f30b55
to
b2eeb0c
Compare
@williambdean do you want to review? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7844 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 107 107
Lines 18286 18301 +15
=======================================
+ Hits 16991 17005 +14
- Misses 1295 1296 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, you OSS legend
b23a979
to
e9dcc27
Compare
Closes #7397
Also when working on #7820 I noticed our detection of observed variables was based on old behavior where only Cast operations were allowed in the graph. This PR fixes that as well
📚 Documentation preview 📚: https://pymc--7844.org.readthedocs.build/en/7844/