-
Notifications
You must be signed in to change notification settings - Fork 137
Add compiler_verbose
config flag
#1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
compiler_verbose
config flag
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
==========================================
- Coverage 82.04% 82.04% -0.01%
==========================================
Files 231 231
Lines 52364 52368 +4
Branches 9217 9218 +1
==========================================
+ Hits 42962 42964 +2
- Misses 7094 7095 +1
- Partials 2308 2309 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but need to add a section to docs/library/config.rst
No I shouldn't, that should be generated automatically. It's bad design if it's not and I would open an issue for that |
It's the year 2025 ffs |
In that case could you beef up the help string of the flag a bit, so that in the future when this section is auto-generated, it's helpful. It appears to only do anything in numba mode, and it dprints nodes? I somewhat don't get it. |
Right now it only does that but could be used for whenever we want to output information during compilation (as opposed to during rewrite). The node dprint is because when someone says numba is falling back to objectmode for stuff like AdvancedSubtensor that's not enough info, because there are 99 flavors of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine then, I'm approving, but I will point out that you could have written something shorter than your reply to satisfy my request, rather than the reply itself.
I'm AFK |
It makes it easier for users to let us know what kind of graph isn't actually compiling this way.
📚 Documentation preview 📚: https://pytensor--1520.org.readthedocs.build/en/1520/