Skip to content

Extend C implementation of psi to support negative inputs #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Abhinav-Khot
Copy link
Contributor

@Abhinav-Khot Abhinav-Khot commented Jul 4, 2025

Description

Modified the C implementation of psi to handle negative inputs too using the reflection formula for the digamma function. Added tests to verify the functionality.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1523.org.readthedocs.build/en/1523/

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.04%. Comparing base (2a7f3e1) to head (90714db).
Report is 212 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   81.99%   82.04%   +0.04%     
==========================================
  Files         188      231      +43     
  Lines       48553    52365    +3812     
  Branches     8673     9217     +544     
==========================================
+ Hits        39812    42963    +3151     
- Misses       6579     7094     +515     
- Partials     2162     2308     +146     
Files with missing lines Coverage Δ
pytensor/scalar/math.py 87.77% <100.00%> (+0.01%) ⬆️

... and 114 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Abhinav-Khot Abhinav-Khot changed the title Add support for negative values in psi Modify C implementation of psi to handle negative inputs Jul 6, 2025
@Abhinav-Khot Abhinav-Khot changed the title Modify C implementation of psi to handle negative inputs Extend C implementation of psi to support negative inputs Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C implementation of psi doesn't handle negative inputs
1 participant