feat: add wait argument to Model.delete_table
#1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancausey
force-pushed
the
feat/add-wait-for-delete-table
branch
from
0e8849a to
ba5bb5b
Compare
|
@ikonst do I need to open an issue for this PR or is this good enough to be reviewed on its own? I was trying to integrate PynamoDB models into FactoryBoy and mimic the DjangoORM behavior of dropping and re-creating the db on each test, but found the |
|
No need for an issue ;) I'll get to it soon! |
ryancausey
force-pushed
the
feat/add-wait-for-delete-table
branch
from
ba5bb5b to
1413852
Compare
ikonst
reviewed
May 23, 2025
ikonst
reviewed
May 23, 2025
ryancausey
force-pushed
the
feat/add-wait-for-delete-table
branch
from
1413852 to
23c0eff
Compare
|
@ikonst not sure if GitHub automatically pings you when I request a review, but this is ready for re-review. |
|
Can you also update docs/release_notes.rst? I assume for version 6.1.0... |
This adds a `wait` argument that will make the `delete_table` call block until the DynamoDB table is fully deleted if set to `True`. It defaults to `False` to not break the existing behavior.
ryancausey
force-pushed
the
feat/add-wait-for-delete-table
branch
from
23c0eff to
d7676cc
Compare
|
@ikonst release notes added. |
ikonst
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
waitargument that will make thedelete_tablecall block until the DynamoDB table is fully deleted if set toTrue. It defaults toFalseto not break the existing behavior.