-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Make the revision part percent-encoded in version control URLs #13407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Attempting to fix #10226 |
We need to add test cases. |
Added. |
Thanks for the PR, it may take some time to review as maintainers capacity is very limited. A couple of quick questions:
|
The only case usage will change is when any revision or branch name has % characters, and those percents will have to be encoded as %25 then, although I don't know if it worked without the encoding previously. Users must modify I will add a simple example later. Thanks. |
We should call this out in the |
Updated the news entry with more details. |
This PR changes how the revision specification is handled in version control URLs. When a branch name contains special characters such as '@' or '#', they must be percent-encoded in URLs; however, this is not currently implemented.
Fixes #10226