Add ruff rules PIE810 multiple-starts-ends-with

[cclauss]

https://docs.astral.sh/ruff/rules/#flake8-pie-pie

• https://docs.astral.sh/ruff/rules/multiple-starts-ends-with

Fix eight instances of:
% ruff rule PIE810

The startswith and endswith methods accept tuples of prefixes or suffixes respectively.
Passing a tuple of prefixes or suffixes is more efficient and readable than calling the method multiple times.

References

• Python documentation: str.startswith
• Python documentation: str.endswith

These transformations to reduce unnecessary repetitive function calls have been recommended since 2006 when they were introduced in Python 2.5

[notatallshaw]

Thanks for the PR contribution, be aware that maintainer time is limited, so reviews may take a while.

One comment, there’s been some discussion around reducing pip’s exposure to Ruff’s linting rules, especially entire groups that may introduce new rules or change existing ones between releases.

Therefore, I think It would make more sense to only add individual PIE rules with specific justification. Personally, I think PIE810 makes sense to include, but looking through the rest of the rules here: https://docs.astral.sh/ruff/rules/#flake8-pie-pie, none of them stand out to me as having particularly strong justifications. But I'm willing to be persuaded.

[cclauss]

Understood. Given that all other PIE rules already pass on this codebase, I would be OK to only enforcing PIE810.

[uranusjr]

If all other rules already pass, it’d probably be easier to have one trivial PR to enable all PIE rules except 810, and then another one to enable PIE810.

[notatallshaw]

If all other rules already pass, it’d probably be easier to have one trivial PR to enable all PIE rules except 810, and then another one to enable PIE810.

I was advocating for not adding the PIE rules as a group, and only adding PIE810 and any other rules which appear to have a strong justification, based on the discussion that happened in this PR #13284.

[cclauss]

We now only enforce one rule, not the whole PIE family of rules.

[notatallshaw]

@cclauss Thanks for your contribution.