-
Notifications
You must be signed in to change notification settings - Fork 317
Python 3 is the default nowadays #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding your PR's intent here, but this option doesn't have to do with Python 3 being the default or not: the reason we set 3.x
is because setup-python
strongly encourages the user to set some version; without an explicit version the runner's system Python is used, and that can be unpredictable/unreliable across runner changes.
TL;DR: This setting doesn't have anything to do with Python 2 vs. 3; it's here to make GitHub's CI/CD runners behave consistently. Removing this setting would expose us to default behavior that would be difficult to debug/diagnose since it only happens remotely.
Closing per above. |
@woodruffw Precisely, Am I missing information that is absent from the |
From the
|
I see, thank you. The documentation is not clear enough about |
I agree it could be clearer, although it is mentioned under "x-ranges" in the docs you linked. (More generally, IMO it's an anti-feature that setup-python uses the system Python at all. But that's unfortunately probably pretty baked into their assumptions, I would guess.) |
No need to explicitly require Python 3.