Update model tester handling around hasChildren() #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant upstream changes:
QAbstractItemModelTester: don't rely on hasChildren()
https://codereview.qt-project.org/c/qt/qtbase/+/318767
QAbstractItemModelTester: fix false positive when model has zero columns
https://codereview.qt-project.org/c/qt/qtbase/+/341238
https://bugreports.qt.io/browse/QTBUG-92220
Fix QAbstractItemModelTester false positive
https://codereview.qt-project.org/c/qt/qtbase/+/343539
https://bugreports.qt.io/browse/QTBUG-92886
Fix QAbstractItemModelTester false positive
https://codereview.qt-project.org/c/qt/qtbase/+/345195
Still missing one bigger change which I plan to do separately:
Add tests to QAbstractItemModelTester checking only one change in flight (I15fe1ad1) · Gerrit Code Review