Track in-flight changes in model tester #421
Merged
+188
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
previously approved these changes
Apr 28, 2022
|
Whoops, forgot to push a follow-up fix |
|
Updated now:
|
nicoddemus
previously approved these changes
Apr 30, 2022
Relevant upstream changes: Add tests to QAbstractItemModelTester checking only one change in flight https://codereview.qt-project.org/c/qt/qtbase/+/396208 QAbstractItemModelTester: Fix typos in debug output https://codereview.qt-project.org/c/qt/qtbase/+/408233
|
And another rebase to resolve changelog conflicts 😅 |
nicoddemus
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant upstream change:
Add tests to QAbstractItemModelTester checking only one change in flight
https://codereview.qt-project.org/c/qt/qtbase/+/396208
A bit light on tests unfortunately (read: none added despite lots of new functionality), but so is the upstream change, unfortunately...