Skip to content

Thanks, folks! #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged

Thanks, folks! #9056

merged 1 commit into from
Jul 6, 2025

Conversation

aclark4life
Copy link
Member

@aclark4life aclark4life commented Jul 1, 2025

As a general rule I think we should acknowledge when significant contribtions come from outside the core team. We know the core team does a lot of work (thank you!) but it's not always obvious when significant contributions come from outside the core team.

In the old change log, we had ACKs via [radarhere] syntax which I miss. I don't expect we'll start using the old change log again but maybe we can make a note in the release notes to include such ACKs as needed and appropriate.

Fixes missing acknowledgments.

Changes proposed in this pull request:

  • Acknowledge non-core team contributors for significant contributions.

As a general rule I think we should acknowledge when significant
contribtions come from outside the core team. We know the core team
does a lot of work (thank you!) but it's not always obvious when
significant contributions come from outside the core team.

In the old change log, we had ACKs via `[radarhere]` syntax which I
miss. I don't expect we'll start using the old change log again but
maybe we can make a note in the release notes to include such ACKs as
needed and appropriate.
@aclark4life
Copy link
Member Author

For example, when folks here are not in the core team and the contribution was significant (more than 5 minutes of work) we should add those folks to the release notes: https://github.com/python-pillow/Pillow/releases/tag/11.3.0

@aclark4life aclark4life requested a review from hugovk July 5, 2025 16:04
@radarhere radarhere merged commit dc9e0cf into main Jul 6, 2025
7 checks passed
@radarhere radarhere deleted the thanks-russell branch July 6, 2025 23:48
@hugovk
Copy link
Member

hugovk commented Jul 7, 2025

By the way, similar to the old changelog, the releases at https://github.com/python-pillow/Pillow/releases do have acknowledge the primary PR authors.

@aclark4life
Copy link
Member Author

By the way, similar to the old changelog, the releases at https://github.com/python-pillow/Pillow/releases do have acknowledge the primary PR authors.

Right, I think that's what I was trying to say in my comment above but in rereading now I see I didn't make that point. 😄 The ACKs in the GitHub release notes can be selectively included in the docs release notes IF they are significant enough to be included in the docs release notes (many are not in the docs release notes) AND they include contributors outside the core team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants