Skip to content

Add error message for empty string in filedataloader. #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Special case empty string/ nullpointer to provide a better error message in that case.

Differential Revision: D72981574

@JacobSzwejbka JacobSzwejbka requested a review from lucylq as a code owner April 14, 2025 19:00
Copy link

pytorch-bot bot commented Apr 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10145

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2dfab6d with merge base 1eb9546 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72981574

Summary:

Special case empty string/ nullpointer to provide a better error message in that case.

Differential Revision: D72981574
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72981574

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@facebook-github-bot facebook-github-bot merged commit 047bbc7 into pytorch:main Apr 15, 2025
83 of 85 checks passed
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Differential Revision: D72981574

Pull Request resolved: pytorch#10145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants