Skip to content

Refactor _get_source_transforms to remove args #10519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Refactor _get_source_transforms to remove args #10519

merged 1 commit into from
May 13, 2025

Conversation

jackzhxng
Copy link
Contributor

Refactor _get_source_transforsm to remove args

@jackzhxng jackzhxng requested a review from lucylq as a code owner April 28, 2025 15:48
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10519

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 32636f5 with merge base df8fc61 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@jackzhxng jackzhxng force-pushed the jz/refactor_source_transforms branch 2 times, most recently from ff5e6d9 to 51a0583 Compare April 28, 2025 19:53
@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

iseeyuan
iseeyuan reviewed Apr 28, 2025
View reviewed changes
examples/models/llama/export_llama_lib.py
@@ -1196,12 +1259,25 @@ def _get_source_transforms( # noqa
transformations based on the given checkpoint first. In those cases,
this wil be a no-op.
"""
modelname = f"{modelname}_e"
# Create a mock args object with the necessary attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to limit the extend of changes? It's better than Namespace, but I'm wondering if eventually we need to group args, and there can still be passing the entire args even not all fields are needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this is just to limit the changes, after I do a final refactor of the quant source transform functions we can remove this

iseeyuan
iseeyuan approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great improvement from passing Namespace directly. Thanks @jackzhxng !

facebook-github-bot pushed a commit that referenced this pull request May 12, 2025
@jackzhxng @facebook-github-bot
Refactor _get_source_transforms to remove args (#10519)
20ec41d 
Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 51a0583 to 20ec41d Compare May 12, 2025 19:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot pushed a commit that referenced this pull request May 12, 2025
@jackzhxng @facebook-github-bot
Refactor _get_source_transforms to remove args (#10519)
41536ab 
Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 20ec41d to 41536ab Compare May 12, 2025 21:47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot pushed a commit that referenced this pull request May 12, 2025
@jackzhxng @facebook-github-bot
Refactor _get_source_transforms to remove args (#10519)
cfc40c2 
Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_source_transforms branch from 41536ab to cfc40c2 Compare May 12, 2025 21:56
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73800023

facebook-github-bot pushed a commit that referenced this pull request May 12, 2025
@jackzhxng @facebook-github-bot
Refactor _get_source_transforms to remove args (#10519)
af4edc6 
Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_source_transforms branch from cfc40c2 to af4edc6 Compare May 12, 2025 22:05
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73800023

@jackzhxng @facebook-github-bot
Refactor _get_source_transforms to remove args (#10519)
32636f5 
Summary:
Refactor `_get_source_transforsm` to remove args


Reviewed By: iseeyuan

Differential Revision: D73800023

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_source_transforms branch from af4edc6 to 32636f5 Compare May 12, 2025 22:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73800023

@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label May 12, 2025
@facebook-github-bot facebook-github-bot merged commit 6f4df1a into main May 13, 2025
91 of 95 checks passed
@facebook-github-bot facebook-github-bot deleted the jz/refactor_source_transforms branch May 13, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iseeyuan iseeyuan iseeyuan approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackzhxng @facebook-github-bot @iseeyuan