Skip to content

Refactor _to_edge_and_lower_llama to remove args #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

jackzhxng
Copy link
Contributor

Refactor _to_edge_and_lower_llama_xnnpack and _to_edge_and_lower_llama to remove args

@jackzhxng jackzhxng requested a review from lucylq as a code owner April 28, 2025 16:05
Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10520

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 602eb1c with merge base 27e159e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@facebook-github-bot
Copy link
Contributor

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

facebook-github-bot pushed a commit that referenced this pull request May 12, 2025
Summary:
Refactor `_to_edge_and_lower_llama_xnnpack` and `_to_edge_and_lower_llama` to remove args


Reviewed By: iseeyuan

Differential Revision: D73785343

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_edge_and_lower branch from 3c6d6e0 to 37a84fb Compare May 12, 2025 20:35
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73785343

Summary:
Refactor `_to_edge_and_lower_llama_xnnpack` and `_to_edge_and_lower_llama` to remove args


Reviewed By: iseeyuan

Differential Revision: D73785343

Pulled By: jackzhxng
@facebook-github-bot facebook-github-bot force-pushed the jz/refactor_edge_and_lower branch from 37a84fb to 602eb1c Compare May 12, 2025 21:45
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73785343

@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label May 12, 2025
@facebook-github-bot facebook-github-bot merged commit 4006cd2 into main May 13, 2025
92 of 96 checks passed
@facebook-github-bot facebook-github-bot deleted the jz/refactor_edge_and_lower branch May 13, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants