Skip to content

Unbreak pytree Buck build #10536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Unbreak pytree Buck build #10536

merged 1 commit into from
Apr 29, 2025

Conversation

swolchok
Copy link
Contributor

D73688265/#10441 broke it. Apparently nothing covered by OSS unittest-buck uses it.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Apr 28, 2025

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from JacobSzwejbka as a code owner April 28, 2025 23:54
Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10536

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 75 Pending

As of commit 434e3e7 with merge base 6ca0800 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Apr 28, 2025
D73688265/#10441 broke it. Apparently nothing covered by OSS unittest-buck uses it.


ghstack-source-id: 534ddec
ghstack-comment-id: 2837041003
Pull-Request-resolved: #10536
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@swolchok
Copy link
Contributor Author

I tried OSS-buckifying the pytree build real quick, but it seems we have cpp_python_extension in extension/pytree/TARGETS and that's not supported right now.

@swolchok
Copy link
Contributor Author

(I spot-checked a broken build internally.)

@swolchok swolchok merged commit 22ba09e into main Apr 29, 2025
86 of 89 checks passed
@swolchok swolchok deleted the gh/swolchok/432/head branch April 29, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants