Skip to content

Add tools/cmake to unittests #10752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025
Merged

Add tools/cmake to unittests #10752

merged 6 commits into from
May 7, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 7, 2025

Summary

TSIA

Test plan

CI + check if tools/cmake tests are listed:

$ pytest --collect-only

...
  <Package tools>
    <Package cmake>
      <Package common>
        <Module preset_test.py>
          <UnitTestCase TestPreset>
            <TestCaseFunction test_create_workspace>
            <TestCaseFunction test_define_overridable_config_cli_override>
            <TestCaseFunction test_define_overridable_config_cli_override_with_set_override>
            <TestCaseFunction test_define_overridable_config_default>
            <TestCaseFunction test_define_overridable_config_invalid_name>
            <TestCaseFunction test_define_overridable_config_invalid_type>
            <TestCaseFunction test_define_overridable_config_set_override_after_with_cache>
            <TestCaseFunction test_define_overridable_config_set_override_before>
            <TestCaseFunction test_set_option>
            <TestCaseFunction testdefine_overridable_config_set_override_after>
...

cc @larryliu0820

Copy link

pytorch-bot bot commented May 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10752

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 939e4f6 with merge base c837925 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2025
@jathu jathu force-pushed the jathu/test-cmake branch from 5e5c9d6 to 6eac9ce Compare May 7, 2025 18:09
@jathu jathu requested a review from larryliu0820 May 7, 2025 18:10
@jathu jathu marked this pull request as ready for review May 7, 2025 18:10
Base automatically changed from jathu/create-define-config to main May 7, 2025 19:52
@jathu jathu added topic: not user facing release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch and removed release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 7, 2025
@jathu jathu merged commit 6af42d7 into main May 7, 2025
84 of 88 checks passed
@jathu jathu deleted the jathu/test-cmake branch May 7, 2025 21:46
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
### Summary
TSIA

### Test plan

CI + check if `tools/cmake` tests are listed:

```
$ pytest --collect-only

...
  <Package tools>
    <Package cmake>
      <Package common>
        <Module preset_test.py>
          <UnitTestCase TestPreset>
            <TestCaseFunction test_create_workspace>
            <TestCaseFunction test_define_overridable_config_cli_override>
            <TestCaseFunction test_define_overridable_config_cli_override_with_set_override>
            <TestCaseFunction test_define_overridable_config_default>
            <TestCaseFunction test_define_overridable_config_invalid_name>
            <TestCaseFunction test_define_overridable_config_invalid_type>
            <TestCaseFunction test_define_overridable_config_set_override_after_with_cache>
            <TestCaseFunction test_define_overridable_config_set_override_before>
            <TestCaseFunction test_set_option>
            <TestCaseFunction testdefine_overridable_config_set_override_after>
...
```

cc @larryliu0820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants