: constant fold None #10762
Merged
: constant fold None #10762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10762
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ce7b6f9 with merge base d25ce54 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
eb21417 to
f8c24fe
Compare
ThomasJannaud
added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Constant folding should fold 'None' and consider it a constant This goes with D74350331 and D74349918 but keeping things separate Differential Revision: D74350331
ThomasJannaud
added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Constant folding should fold 'None' and consider it a constant This goes with D74350331 and D74349918 but keeping things separate Differential Revision: D74350331
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
f8c24fe to
8cb11d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
ThomasJannaud
added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Pull Request resolved: pytorch#10762 Constant folding should fold 'None' and consider it a constant This goes with D74350331 and D74349918 but keeping things separate Differential Revision: D74350331
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
8cb11d8 to
d37c47d
Compare
ThomasJannaud
added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Constant folding should fold 'None' and consider it a constant This goes with D74350331 and D74349918 but keeping things separate Differential Revision: D74350331
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
d37c47d to
bee0a04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
| @@ -61,6 +61,8 @@ def is_const( | |||
| ) | |||
| elif isinstance(arg, _PRIMITIVE_TYPES): | |||
| return True | |||
| elif arg is None: | |||
There was a problem hiding this comment.
was the problem before that const prop would skip nodes with None in the args?
There was a problem hiding this comment.
yes, I think the issue is None is not a constant, and so if an op has args that include constants and None, it doesn't get constant folded.
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
bee0a04 to
e11d813
Compare
ThomasJannaud
added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Constant folding should fold 'None' and consider it a constant This goes with D74280168 and D74349918 but keeping things separate Differential Revision: D74350331
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
metascroy
approved these changes
May 8, 2025
Summary: Constant folding should fold 'None' and consider it a constant This goes with D74280168 and D74349918 but keeping things separate Reviewed By: metascroy Differential Revision: D74350331
ThomasJannaud
force-pushed
the
export-D74350331
branch
from
e11d813 to
ce7b6f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74350331 |
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
Differential Revision: D74350331 Pull Request resolved: pytorch#10762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Constant folding should fold 'None' and consider it a constant
This goes with D74350331 and D74349918 but keeping things separate
Differential Revision: D74350331