Skip to content

Introduce assertj test lib to make the throw exception test more accu… #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2025

Conversation

phaiting
Copy link
Contributor

@phaiting phaiting commented May 9, 2025

Summary

This change introduced the assertj test lib to make the throw exception testing more accurate

Test plan

./gradlew :executorch_android:testDebugUnitTest

@phaiting phaiting requested a review from kirklandsign as a code owner May 9, 2025 02:59
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10779

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 11 Pending

As of commit c82c624 with merge base b1b46ee (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@phaiting
Copy link
Contributor Author

phaiting commented May 9, 2025

@pytorchbot label "topic: not user facing"

@kirklandsign
Copy link
Contributor

linter

@kirklandsign
Copy link
Contributor

Failures are unrelated.

@kirklandsign
Copy link
Contributor

Thank you! 🚀 🚀

@phaiting phaiting merged commit b173722 into main May 10, 2025
80 of 86 checks passed
@phaiting phaiting deleted the introduce-assertj branch May 10, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants