-
Notifications
You must be signed in to change notification settings - Fork 539
Remove FLATC_EXECUTABLE and the ability to bring your own flatc #10781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10781
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 PendingAs of commit ce4507c with merge base 6e959be ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
275837c
to
5f62193
Compare
5f62193
to
ce4507c
Compare
set_target_properties(flatc PROPERTIES IMPORTED_LOCATION ${BINARY_DIR}/flatc) | ||
endif() | ||
|
||
# TODO: re-enable once flatbuffers is added as a subdirectory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to stop directly reaching into flatbuffers, and instead use the flatbuffer
library target:
"${EXECUTORCH_ROOT}/third-party/flatbuffers/include" |
I'll do it in some future diff
Summary
EXECUTORCH_BUILD_FLATC
third-party/CMakeLists.txt
to keep things organizedFLATBUFFERS_MAX_ALIGNMENT
to be configurableTest plan
CI
cc @larryliu0820