Skip to content

Arm backend: Suppress colors in pre-push if non-interactive #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

perheld
Copy link
Collaborator

@perheld perheld commented May 9, 2025

Dont try to print with colors in the pre-push script if the script is non-interactive. This is to avoid getting broken output in the CI which doesnt support colors.

Signed-off-by: [email protected]

Change-Id: I58b6a45de8b8403fa39ecbe299d380f3ca9fba62

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner May 9, 2025 06:08
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10783

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 36b9160 with merge base b1b46ee (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 9, 2025
Dont try to print with colors in the pre-push script if the script is
non-interactive. This is to avoid getting broken output in the CI
which doesnt support colors.

Signed-off-by: [email protected]

Change-Id: I58b6a45de8b8403fa39ecbe299d380f3ca9fba62
@perheld perheld force-pushed the upstream/ph-git-pre-push-non-interactive branch from 6b6eceb to 36b9160 Compare May 9, 2025 06:09
@zingo
Copy link
Collaborator

zingo commented May 9, 2025

Macos fail unrelated

@zingo zingo merged commit 54a14d9 into pytorch:main May 9, 2025
355 of 360 checks passed
@perheld perheld deleted the upstream/ph-git-pre-push-non-interactive branch May 9, 2025 11:14
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
…10783)

Dont try to print with colors in the pre-push script if the script is
non-interactive. This is to avoid getting broken output in the CI which
doesnt support colors.

Signed-off-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants