Skip to content

[ET-VK] Return fence after waiting is done. #10787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented May 9, 2025

Stack from ghstack (oldest at bottom):

This change returns a fence to fence pool after it has been waited on.

Differential Revision: D74484825

This change returns a fence to fence pool after it has been waited on.

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10787

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 20ad844 with merge base bf50527 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

trivedivivek added a commit that referenced this pull request May 9, 2025
This change returns a fence to fence pool after it has been waited on.

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)

ghstack-source-id: 283068750
Pull Request resolved: #10787
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484825

Copy link

github-actions bot commented May 9, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This change returns a fence to fence pool after it has been waited on.

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request May 9, 2025
Pull Request resolved: #10787

This change returns a fence to fence pool after it has been waited on.
ghstack-source-id: 283086314
@exported-using-ghexport

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484825

This change returns a fence to fence pool after it has been waited on.

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request May 12, 2025
Pull Request resolved: #10787

This change returns a fence to fence pool after it has been waited on.
ghstack-source-id: 283339435
@exported-using-ghexport

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74484825

@facebook-github-bot facebook-github-bot merged commit 9ebf5ef into gh/trivedivivek/86/base May 12, 2025
87 of 88 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/86/head branch May 12, 2025 03:35
kirklandsign pushed a commit that referenced this pull request May 12, 2025
Pull Request resolved: #10787

This change returns a fence to fence pool after it has been waited on.
ghstack-source-id: 283339435
@exported-using-ghexport

Differential Revision: [D74484825](https://our.internmc.facebook.com/intern/diff/D74484825/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants