Skip to content

[Executorch][llm] Make custom update cache op operate on indices #10834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10610 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/186/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/187/orig
@diff-train-skip-merge

Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10834

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 3 Pending

As of commit b994a1a with merge base 0bb059f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@kimishpatel kimishpatel force-pushed the gh/kimishpatel/186/orig branch from 0cab6ab to aaf996b Compare May 13, 2025 14:27
Base automatically changed from gh/kimishpatel/186/orig to main May 13, 2025 14:29
Pull Request resolved: #10610

This allows us to use ring buffer kv cache
ghstack-source-id: 283404676
@exported-using-ghexport

Differential Revision: [D73891424](https://our.internmc.facebook.com/intern/diff/D73891424/)
@kimishpatel kimishpatel force-pushed the gh/kimishpatel/187/orig branch from bfcaf89 to b994a1a Compare May 13, 2025 14:31
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel kimishpatel merged commit 0b231c4 into main May 13, 2025
91 of 92 checks passed
@kimishpatel kimishpatel deleted the gh/kimishpatel/187/orig branch May 13, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants