Skip to content

Arm backend: Add test for DeiT Tiny for TOSA BI #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented May 13, 2025

Add test case for the DeiT Tiny model for the TOSA BI profile. At this time the output of the model differs from the reference implementation by a mean absolute error of around 2.5, which is too high. An internal ticket has been raised to resolve this issue.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add test case for the DeiT Tiny model for the TOSA BI profile. At this
time the output of the model differs from the reference implementation
by a mean absolute error of around 2.5, which is too high. An internal
ticket has been raised to resolve this issue.

Signed-off-by: Martin Lindström <[email protected]>
Change-Id: I9f3223068d35fa6f3e485e0fb12ad49bb8b3d534
@martinlsm martinlsm requested a review from mansnils May 13, 2025 09:26
@martinlsm martinlsm requested a review from digantdesai as a code owner May 13, 2025 09:26
Copy link

pytorch-bot bot commented May 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10846

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit bf654f8 with merge base 7993bb2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 13, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@zingo zingo added the release notes: none Do not include this in the release notes label May 13, 2025
aten_op=[],
exir_op=[],
use_to_edge_transform_and_lower=True,
atol=3.0, # This needs to go down: MLETORCH-956
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it stable though? As opposed to flaky, else we can mark it as Flaky..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digantdesai I believe it is rather stable. Been looping it several times myself and the numerical error looks to be consistent.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More transformers! Let's go.

@zingo zingo merged commit b058afb into pytorch:main May 15, 2025
254 of 259 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants