Skip to content

Adding more explicit error code #12427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding more explicit error code #12427

wants to merge 1 commit into from
+14 −5

Conversation

yunquan812
Copy link

Summary: {title}, the Internal and InvalidArgument errors don't tell what is really going wrong

Differential Revision: D78233596

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12427

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 4cdf11e with merge base ee9e6d9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78233596

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

swolchok
swolchok reviewed Jul 14, 2025
View reviewed changes
runtime/core/error.h Outdated
/*
* Registration errors.
*/
RegistrationExceedingMaxKernels = 0x40,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what our convention is around numbering here but I imagine we should just use the next number. @mergennachin do you know?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are loosely grouped by type with jumps to allow new types in. If anything the original OperatorMissing is in the wrong spot, but since its there already probably just make this error 0x15 @yunquan812

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let me update it :)

yunquan812 pushed a commit to yunquan812/executorch that referenced this pull request Jul 14, 2025
@facebook-github-bot
Adding more explicit error code (pytorch#12427)
b166306 
Summary:

{title}, the `Internal` and `InvalidArgument` errors don't tell what is really going wrong

Differential Revision: D78233596
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78233596

yunquan812 pushed a commit to yunquan812/executorch that referenced this pull request Jul 14, 2025
@facebook-github-bot
Adding more explicit error code (pytorch#12427)
ce5b3c6 
Summary:
Pull Request resolved: pytorch#12427

{title}, the `Internal` and `InvalidArgument` errors don't tell what is really going wrong

Differential Revision: D78233596
@facebook-github-bot
Adding more explicit error code (pytorch#12427)
4cdf11e 
Summary:
Pull Request resolved: pytorch#12427

{title}, the `Internal` and `InvalidArgument` errors don't tell what is really going wrong

Differential Revision: D78233596
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78233596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunquan812 @facebook-github-bot @swolchok @JacobSzwejbka