Fix build_apple_frameworks.sh to use proper EXECUTORCH_ENABLE_LOGGING… #12469
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumikhin
added
the
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12469
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
approved these changes
Jul 15, 2025
|
@pytorchbot cherry-pick --onto release/0.7 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Jul 15, 2025
#12469) EXECUTORCH_ENABLE_LOGGING doesn't pick up based on the build mode, as it should based on [default.cmake](https://github.com/pytorch/executorch/blob/main/tools/cmake/preset/default.cmake#L20) Meanwhile macOS preset in macos.cmake always enabled logging due to the fact it includes [pybind.cmake](https://github.com/pytorch/executorch/blob/main/tools/cmake/preset/pybind.cmake#L10-L13) which deliberately enables it with an override. Thus for Apple frameworks build we get logging disabled permanently, except for macos where it's always enabled based on a pretty unrelated pybind settings. (cherry picked from commit bbe90bd)
Cherry picking #12469The cherry pick PR is at #12473 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXECUTORCH_ENABLE_LOGGING doesn't pick up based on the build mode, as it should based on default.cmake
Meanwhile macOS preset in macos.cmake always enabled logging due to the fact it includes pybind.cmake which deliberately enables it with an override.
Thus for Apple frameworks build we get logging disabled permanently, except for macos where it's always enabled based on a pretty unrelated pybind settings.