Skip to content

Remove to_edge_with_preserve_ops #12472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gh/lucylq/92/base
Choose a base branch
from
Open

Remove to_edge_with_preserve_ops #12472

wants to merge 1 commit into from
+1 −51

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jul 15, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Experimental API, no stability guarantees. Replaced with to_edge, which now takes in preserve_ops in the EdgeCompileConfig.

Differential Revision: D78312326

@lucylq
Remove to_edge_with_preserve_ops
b1b9af5 
Experimental API, no stability guarantees. Replaced with to_edge, which now takes in `preserve_ops` in the `EdgeCompileConfig`.

Differential Revision: [D78312326](https://our.internmc.facebook.com/intern/diff/D78312326/)

[ghstack-poisoned]
This was referenced Jul 15, 2025
Open
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12472

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b1b9af5 with merge base 1540659 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Jul 15, 2025
@lucylq
Remove to_edge_with_preserve_ops
029c724 
Experimental API, no stability guarantees. Replaced with to_edge, which now takes in `preserve_ops` in the `EdgeCompileConfig`.

Differential Revision: [D78312326](https://our.internmc.facebook.com/intern/diff/D78312326/)

ghstack-source-id: 296199276
Pull Request resolved: #12472
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78312326

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq
Copy link
Contributor Author

lucylq commented Jul 15, 2025

For issue: #12306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucylq @facebook-github-bot