Skip to content

TCP Debug Logging #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Conversation

ppanchalia
Copy link
Contributor

Differential Revision: D70682977

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

1 similar comment
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

1 similar comment
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

ppanchalia added a commit to ppanchalia/gloo that referenced this pull request Mar 6, 2025
Summary:
Pull Request resolved: pytorch#415

Adds a debug_logger to capture TCP failure debug data

Meta:

Aides debugging for S489966

This multipex a debug_logger for internal, where the data is logged to Scuba: gloo_tcp_debug using LoggerConfig: D70646098
JK: https://www.internalfb.com/intern/justknobs/?name=ai_infra%2Fpytorch_distributed#torch_gloo_disable_tcp_debug_scuba_logging

JK Diff: D70684609

Differential Revision: D70682977
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppanchalia added a commit to ppanchalia/gloo that referenced this pull request Mar 7, 2025
Summary:

Adds a debug_logger to capture TCP failure debug data

Meta:

Aides debugging for S489966

This multipex a debug_logger for internal, where the data is logged to Scuba: gloo_tcp_debug using LoggerConfig: D70646098
JK: https://www.internalfb.com/intern/justknobs/?name=ai_infra%2Fpytorch_distributed#torch_gloo_disable_tcp_debug_scuba_logging

JK Diff: D70684609

Reviewed By: d4l3k

Differential Revision: D70682977
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

Summary:
Pull Request resolved: pytorch#415

Adds a debug_logger to capture TCP failure debug data

Meta:

Aides debugging for S489966

This multipex a debug_logger for internal, where the data is logged to Scuba: gloo_tcp_debug using LoggerConfig: D70646098
JK: https://www.internalfb.com/intern/justknobs/?name=ai_infra%2Fpytorch_distributed#torch_gloo_disable_tcp_debug_scuba_logging

JK Diff: D70684609

Reviewed By: d4l3k

Differential Revision: D70682977
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70682977

@facebook-github-bot facebook-github-bot merged commit 9578bb1 into pytorch:main Mar 8, 2025
3 of 5 checks passed
@ppanchalia ppanchalia deleted the export-D70682977 branch March 8, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants