Update CMake version #424
Merged
Update CMake version #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As cmake-4.0.0 is no longer compatible with cmake-2, but those files are solid cmake-3.x project
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2025
That updates its CMake minimum version(via pytorch/gloo#424 ) and removes cmake-4.0.0 workarounds for gloo Pull Request resolved: #150320 Approved by: https://github.com/atalman
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
That updates its CMake minimum version(via pytorch/gloo#424 ) and removes cmake-4.0.0 workarounds for gloo Pull Request resolved: pytorch#150320 Approved by: https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As cmake-4.0.0 is no longer compatible with cmake-2, but those files are solid cmake-3.x project