Back out "Revert D69698406: gloo: async lazy connect" #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Original commit changeset: 4cfad1d7b700 Original Phabricator Diff: D69698406 *** gloo: only shutdown device when async See original PR for details and test plan: D69698406 This extends that PR with one small change to avoid shutting down Device when using non-async mode to preserve backwards compatibility for caffe2. Reviewed By: fduwjj Differential Revision: D72425729
|
This pull request was exported from Phabricator. Differential Revision: D72425729 |
fduwjj
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 4cfad1d7b700
Original Phabricator Diff: D69698406
gloo: only shutdown device when async
See original PR for details and test plan: D69698406
This extends that PR with one small change to avoid shutting down Device when using non-async mode to preserve backwards compatibility for caffe2.
Reviewed By: fduwjj
Differential Revision: D72425729