gloo: use unbound buffers for barrier, broadcast #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This makes barrier and broadcast operations in Gloo use UnboundBuffer instead of Buffer. UnboundBuffer is the newer preferred buffer implementation and also makes the algorithms much easier to express/understand and efficient since we don't need to allocate more memory. Tracking issue for Buffer removal: #432 Differential Revision: D74096980
|
This pull request was exported from Phabricator. Differential Revision: D74096980 |
fduwjj
approved these changes
May 2, 2025
fduwjj
reviewed
May 2, 2025
| @@ -70,14 +44,21 @@ class BroadcastOneToAll : public Algorithm { | |||
| return; | |||
| } | |||
|
|
|||
| auto clearToSendBuffer = context_->createUnboundBuffer(nullptr, 0); | |||
There was a problem hiding this comment.
N00b question why this is even needed? Is it because we need to wait for the receiver to be ready?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes barrier and broadcast operations in Gloo use UnboundBuffer instead of Buffer. UnboundBuffer is the newer preferred buffer implementation and also makes the algorithms much easier to express/understand and efficient since we don't need to allocate more memory.
Tracking issue for Buffer removal: #432
Differential Revision: D74096980