Skip to content

[WIP] This should work but it doesn't #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

[WIP] This should work but it doesn't #472

Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
16d698f
Start implementation of approximate mode
scotts Dec 16, 2024
9a5abce
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Dec 18, 2024
d95b128
Initial seek mode implementation in VideoDecoder.
scotts Dec 19, 2024
97ac764
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Dec 19, 2024
35f2e59
Added Python side support, extended tests.
scotts Dec 20, 2024
8c9aeac
Apply lints
scotts Dec 20, 2024
921b822
Default C++ tests to approximate mode
scotts Dec 20, 2024
b349282
Apply lints
scotts Dec 20, 2024
081a5bb
Updated metadata; all tests pass.
scotts Dec 20, 2024
802b881
Removed commened out code.
scotts Dec 20, 2024
911a3bc
Consolidated logic for timestamp batch. Big perf win.
scotts Dec 20, 2024
7267b5a
Consolidated logic for timestamp range.
scotts Dec 21, 2024
ae44f78
More mode consolidation.
scotts Dec 21, 2024
e4edaf4
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Jan 9, 2025
64ebefe
Merge branch 'main' into approx
NicolasHug Jan 10, 2025
f62af46
Provide constructor param names
scotts Jan 11, 2025
d15dfa0
getFramesSize -> getNumFrames
scotts Jan 11, 2025
8879c32
Use seek_mode to paramterize metadata tests
scotts Jan 11, 2025
8443de5
stream -> streamInfo
scotts Jan 11, 2025
446910d
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Jan 11, 2025
ebebb63
Merge branch 'approx' of github.com:scotts/torchcodec into approx
scotts Jan 11, 2025
e34ca31
seek -> seekMode
scotts Jan 11, 2025
67c1225
remove getFramePlayedAtTimestampNoDemuxInternal
scotts Jan 11, 2025
d13879d
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Jan 14, 2025
06bb2c3
Rationalize time based samplers and valid metadata
scotts Jan 14, 2025
8ed3c5e
Refactor setting and using scanned number of frames
scotts Jan 14, 2025
bc10db8
Tweak FrameInfo struct initialization
scotts Jan 14, 2025
a6a2b6a
Use validateFrameIndex in getFramesInIndices
scotts Jan 14, 2025
3cd6842
Update src/torchcodec/decoders/_video_decoder.py
scotts Jan 14, 2025
9a46404
Tweak VideoDecoder doc string
scotts Jan 14, 2025
f4c001b
Remove comment
scotts Jan 15, 2025
4574e95
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Jan 17, 2025
abad57b
FrameInfo struct initialization
scotts Jan 17, 2025
737e1b6
Remove explicit setting of seek_mode in unrelated tests
scotts Jan 21, 2025
99b0d4f
Merge branch 'main' of github.com:pytorch/torchcodec into approx
scotts Jan 21, 2025
32a0f8f
Handle stream names
NicolasHug Jan 22, 2025
64f4595
Handle frame names
NicolasHug Jan 22, 2025
c629073
Streams again
NicolasHug Jan 22, 2025
85569fb
metadata names
NicolasHug Jan 22, 2025
d914615
Handle options
NicolasHug Jan 22, 2025
621a64c
Frame again
NicolasHug Jan 22, 2025
f247884
Lint
NicolasHug Jan 22, 2025
55a5840
More videoStreamOptions
NicolasHug Jan 22, 2025
793c876
Merge branch 'main' of github.com:pytorch/torchcodec into renamingzzzz
NicolasHug Jan 22, 2025
79ea167
reduce diff
NicolasHug Jan 22, 2025
404b2e4
Fix C++ tests
NicolasHug Jan 22, 2025
941d6a3
Fix CUDA?
NicolasHug Jan 22, 2025
11779a7
Merge branch 'main' of github.com:pytorch/torchcodec into renamingzzzz
NicolasHug Jan 23, 2025
a7c5711
Use allStreamMetadata
NicolasHug Jan 23, 2025
16d5e52
Rename BatchDecodedOutput into FrameBatchOutput
NicolasHug Jan 23, 2025
78b095a
Rename RawDecodedOutput into AVFrameWithStreamIndex
NicolasHug Jan 23, 2025
e1e46ff
Rename DecodedOutput into FrameOutput
NicolasHug Jan 23, 2025
cd0a181
Rename .frames into .data
NicolasHug Jan 23, 2025
0111bfc
rename .frame to .data
NicolasHug Jan 23, 2025
42ea096
Use frameBatchOutput variable name
NicolasHug Jan 23, 2025
3a2ab2d
rename getFrameOutputWithFilter
NicolasHug Jan 23, 2025
05da318
Use frameOutput name
NicolasHug Jan 23, 2025
a6a47f1
lint
NicolasHug Jan 23, 2025
d1352fe
Merge branch 'main' of github.com:pytorch/torchcodec into framezzzzz
NicolasHug Jan 23, 2025
658b727
getNextAVFrameNoDemux
NicolasHug Jan 23, 2025
62818a7
more stuff
NicolasHug Jan 23, 2025
24d0035
use avFrameWithStreamIndex
NicolasHug Jan 23, 2025
a1805d1
Cpp tests
NicolasHug Jan 23, 2025
eb1773a
more
NicolasHug Jan 23, 2025
21b8ff2
Remove getNextAVFrameNoDemux
NicolasHug Jan 23, 2025
dac4463
Rename maybeDesiredPts_ into desiredPts_
NicolasHug Jan 23, 2025
bc024eb
Merge branch 'desiredPTs' into aelfjnalefjnalfjenljaenf
NicolasHug Jan 23, 2025
a17027c
this should work
NicolasHug Jan 23, 2025
738a262
Merge branch 'main' of github.com:pytorch/torchcodec into this_should…
NicolasHug Jan 23, 2025
86c6ffd
Try
NicolasHug Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into approx
  • Loading branch information
@NicolasHug
NicolasHug authored Jan 10, 2025
commit 64ebefe5c3fefd1a02b16762c2c5e0630c1c0ec1

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.