Fix pts <-> seconds conversions #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
May 15, 2025
| containerMetadata_.durationSeconds = | ||
| ptsToSeconds(formatContext_->duration, AV_TIME_BASE); | ||
| ptsToSeconds(formatContext_->duration, defaultTimeBase); |
There was a problem hiding this comment.
Drive-by: I've been annoyed by the existence of double ptsToSeconds(int64_t pts, int den), so I'm removing it.
defaultTimeBase corresponds to FFmpeg's AV_TIME_BASE_Q, which we can't use due to a C++ pendantic compilation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥶
We weren't multiplying by
timeBase.num. All the videos we've been testing on so far had atimebase.num == 1, so the bug went unnoticed.