Skip to content

Add AudioEncoder public Python API #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add AudioEncoder public Python API #692

wants to merge 2 commits into from

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 21, 2025 •
edited
Loading

This PR exposes a simple AudioEncoder object, following "Option 2" from #690.

More tests and doc will come in follow-ups. There are already plenty of tests in test_ops.py

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 21, 2025
scotts
scotts approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@scotts scotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some basic tests that succeed in follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotts scotts scotts approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @scotts @facebook-github-bot