test allreduce failures for diloco #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
reviewed
Jun 24, 2025
torchft/manager.py
Outdated
| # used to artificially fail the next allreduce by tests | ||
| self._TEST_should_fail_allreduce = False | ||
|
|
||
| def TEST_fail_allreduce(self) -> None: |
There was a problem hiding this comment.
can we create a wrapped/mocked PG that injects the failure instead?
There was a problem hiding this comment.
yeah let me see if we can create a wrapper so we can keep using real pg. thinking of using mocked pg for deterministic simulation
There was a problem hiding this comment.
agree that we should try to keep test related functionality contained in our test files!
Summary: - test when allreduce fails but no new nodes join - added another event of type `AllreduceFailure` - This new event required modifying some manager code to inject the failure
H-Huang
reviewed
Jun 28, 2025
| @@ -1016,6 +1023,55 @@ def allreduce(self, tensors: List[torch.Tensor], opts: object) -> Work: | |||
| return _DummyWork(tensors) | |||
|
|
|||
|
|
|||
| class FakeProcessGroupWrapper(ProcessGroupWrapper): | |||
There was a problem hiding this comment.
nit: could maybe move this class into tests?
There was a problem hiding this comment.
yeah there's a bunch of other fakes in this file. maybe take this up separately? we also want to upstream process_group to pytorch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AllreduceFailure