Skip to content

[Fux] load AutoencoderKL from diffusers #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Apr 10, 2025

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 10, 2025
@wwwjn wwwjn self-requested a review April 10, 2025 17:36
@@ -65,17 +54,6 @@
theta=10_000,
qkv_bias=True,
guidance_embed=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also remove line from torchtitan.experiments.flux.model.autoencoder import AutoEncoderParams
` in the beginning of this file.

Copy link
Contributor

@wwwjn wwwjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I feel like this change would make flux code base simpler, but we need an extra dependency. In general we would love to keep decencies as less as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants