fix using count to get string length & header setter #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 22 22
Lines 1583 1583
=======================================
Hits 1411 1411
Misses 172 172
Continue to review full report at Codecov.
|
tianyiw2013
approved these changes
Mar 26, 2022
tianyiw2013
reviewed
Mar 26, 2022
| @@ -114,7 +114,7 @@ public function signQiniuAuthorization($urlString, $method = "GET", $body = "", | |||
|
|
|||
| // append body | |||
| $data .= "\n\n"; | |||
| if (count($body) > 0 | |||
| if (strlen($body) > 0 | |||
lihsai0
force-pushed
the
fix/count-string
branch
from
4b799d5 to
5b1bf18
Compare
lihsai0
changed the title
bachue
approved these changes
Mar 30, 2022
|
close #379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix warning under php 7.4
fix header setter
内部工单 KODO-14447