Skip to content

feat: enhance detailing functionality with breadcrumb support #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

feat: enhance detailing functionality with breadcrumb support #981

merged 3 commits into from
Jun 3, 2025

Conversation

zhangshanwen
Copy link
Contributor

  • Added a breadcrumb function to the DetailingBuilder, allowing for dynamic breadcrumb generation based on the current context.
  • Updated the default page function to utilize the breadcrumb functionality.
  • Modified the page rendering to include breadcrumbs in the layout, improving navigation and user experience.
  • Updated go.mod and go.sum for dependency management.

@zhangshanwen
feat: enhance detailing functionality with breadcrumb support
c84712b 
- Added a breadcrumb function to the DetailingBuilder, allowing for dynamic breadcrumb generation based on the current context.
- Updated the default page function to utilize the breadcrumb functionality.
- Modified the page rendering to include breadcrumbs in the layout, improving navigation and user experience.
- Updated go.mod and go.sum for dependency management.
@zhangshanwen zhangshanwen requested a review from molon May 29, 2025 09:40
@deepsource-autofix
style: format code with Gofumpt
3067bc4 
This commit fixes the style issues introduced in c84712b according to the output
from Gofumpt.

Details: #981
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented May 29, 2025 •
edited
Loading

Here's the code health analysis summary for commits c3715bf..d0a3d3c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo❌ Failure
❗ 24 occurences introduced
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.51807% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
presets/detailing.go 75.43% 11 Missing and 3 partials ⚠️
pagebuilder/page.go 70.00% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
presets/model.go 89.41% <100.00%> (+0.11%) ⬆️
presets/presets.go 80.44% <100.00%> (+0.29%) ⬆️
pagebuilder/page.go 91.24% <70.00%> (-2.34%) ⬇️
presets/detailing.go 69.23% <75.43%> (+2.67%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhangshanwen zhangshanwen merged commit f6f12aa into main Jun 3, 2025
8 of 9 checks passed
@zhangshanwen zhangshanwen deleted the feat-breadcrumb branch June 3, 2025 06:42
@zhangshanwen zhangshanwen mentioned this pull request Jun 3, 2025
Merged
@zhangshanwen zhangshanwen restored the feat-breadcrumb branch June 3, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molon molon molon approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangshanwen @molon @theplant-ci