Add golangci-lint static check #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiimjako
force-pushed
the
golang-ci-static-check
branch
from
3b2f077 to
a424933
Compare
hiimjako
force-pushed
the
golang-ci-static-check
branch
2 times, most recently
from
adc63b6 to
1a4be1f
Compare
hiimjako
force-pushed
the
golang-ci-static-check
branch
from
1a4be1f to
710cef8
Compare
|
It looks good to me. Have you tried the reliable example? To ensure everything works properly. Thank you |
Yes, I tried, it is working as expected: ❯ go run ./examples/reliable/reliable_client.go
Reliable Producer/Consumer example
Connecting to RabbitMQ streaming ...
Environment created with 1 producers and 1 consumers
********************************************
Tuesday, 17-Jun-25 10:11:26 CEST - ToSend: 20000000 - nProducers: 1 - concurrentProducers: 1 - nConsumers 1
Sent:0 - ReSent:0 - Confirmed:0 - Not confirmed:0 - Fail+Confirmed:0
Total Consumed:0 - Per consumer:0
go-routine: 5
********************************************
Press enter to close the connections.
********************************************
Tuesday, 17-Jun-25 10:11:31 CEST - ToSend: 20000000 - nProducers: 1 - concurrentProducers: 1 - nConsumers 1
Sent:718641 - ReSent:0 - Confirmed:718584 - Not confirmed:0 - Fail+Confirmed:718584
Total Consumed:540551 - Per consumer:540551
producer producer-0 for stream golang-reliable-Test, status: Open
consumer go-stream-consumer for stream golang-reliable-Test, status: Open
go-routine: 16
********************************************
********************************************
Tuesday, 17-Jun-25 10:11:36 CEST - ToSend: 20000000 - nProducers: 1 - concurrentProducers: 1 - nConsumers 1
Sent:1551015 - ReSent:0 - Confirmed:1551002 - Not confirmed:0 - Fail+Confirmed:1551002
Total Consumed:1181423 - Per consumer:1181423
producer producer-0 for stream golang-reliable-Test, status: Open
consumer go-stream-consumer for stream golang-reliable-Test, status: Open
go-routine: 16
******************************************** |
Gsantomaggio
approved these changes
Jun 17, 2025
|
Thank you @hiimjako |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the golangci-lint CLI and applied automatic fixes to resolve warnings.
I've also added a CI workflow
lint, I've also bumped the go version for the test to the latest one1.24for both test and lint.@Gsantomaggio I've removed the unused
system_integrationfolder, since it was all commented out.