Skip to content

Adds eventID to Facebook Pixel #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Adds eventID to Facebook Pixel #161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d25e88b
add eventID param to facebook pixel
alextakitani Jun 24, 2021
3e68607
ignore vscode folder
alextakitani Jun 24, 2021
cbab740
remove vscode folder
alextakitani Jun 24, 2021
ac26498
send eventid as json
alextakitani Jun 24, 2021
beb4786
tag manager can be self hosted
alextakitani Jul 6, 2021
6758f6e
version up
alextakitani Jul 6, 2021
2e04e2c
force tag
alextakitani Jul 6, 2021
d62aee5
static
alextakitani Jul 6, 2021
675c359
use options
alextakitani Jul 6, 2021
660af36
fully replaceable host
alextakitani Jul 7, 2021
b3da5d6
fix noscript tag for google
alextakitani Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tag manager can be self hosted
  • Loading branch information
@alextakitani
alextakitani committed Jul 6, 2021
commit beb47864b03a07133dbef5c606eefe6066897f06
2 changes: 1 addition & 1 deletion lib/rack/tracker/google_global/template/google_global.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% if trackers.any? %>
<script async src='https://www.googletagmanager.com/gtag/js?id=<%= trackers[0][:id] %>'></script>
<script async src='https://www.<%= options[:host].presence || 'googletagmanager' %>.com/gtag/js?id=<%= trackers[0][:id] %>'></script>
<script>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments)};
Expand Down
2 changes: 1 addition & 1 deletion lib/rack/tracker/google_tag_manager/template/google_tag_manager_body.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<% if container %>
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=<%= container %>"
<noscript><iframe src="https://www.<%= options[:host].presence || 'googletagmanager' %>.com/ns.html?id=<%= container %>"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
<% end %>
4 changes: 1 addition & 3 deletions lib/rack/tracker/google_tag_manager/template/google_tag_manager_head.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
"https://www.<%= options[:host].presence || 'googletagmanager' %>.com/gtm.js?id="+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','<%= container %>');</script>
<% end %>