Fixed bug causing IPRange::include? always return false #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleted a statement in IPRange::include? method.
Motivation and Context
The class IPRange, defined in
lib/nexpose/site.rbhas the instance methodinclude?(single_ip), which should check if the given ip address is included in the IPRange instance.The following is the first statement of that method, where
:fromis the attribute containing the start of range:return false unless single_ip.respond_to? :fromsingle_ipshould always be a String object, so the statement will always return false since String does not have any method/attributes called:from.How Has This Been Tested?
This change has been successfully tested on an enterprise environment
Types of changes